Add Discord backend support to MessagingServiceConfig and related tests#265
Closed
neverabsolute wants to merge 5 commits intobugsink:mainfrom
Closed
Add Discord backend support to MessagingServiceConfig and related tests#265neverabsolute wants to merge 5 commits intobugsink:mainfrom
neverabsolute wants to merge 5 commits intobugsink:mainfrom
Conversation
|
|
Contributor
Author
|
Without this piece in the Dockerfile, forks won't build from it. I'll erase this if and when it is ready to merge. |
Contributor
|
This implements #121 |
Contributor
|
I'll take a look at this ASAP; I'll probably just "hijack" the PR to integrate it into main simultaneously with similar work on a mattermost-specific backend (#253) |
Contributor
Would be interested what in particular doesn't build |
Contributor
|
Hijacked/continued here: #279 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Discord as a messaging backend for alerts, alongside the existing Slack integration.
DiscordBackendimplementation inalerts/service_backends/discord.py, including configuration form, test message and alert sending logic, and error/success status handling.MessagingServiceConfigmodel inalerts/models.pyto support akindof"discord"and route backend selection based on this field."discord"as a valid choice for thekindfield.alerts/tests.py, I just copied the existing Slack ones.