Conversation
# Conflicts: # src/Application.php # src/Info.php # src/Proto/Frame/Sentry.php # src/Proto/Server/Version/V1.php # src/Sender/Console/Renderer/Plain.php
…ni config attribute; files observer is created using container now
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #111 +/- ##
============================================
- Coverage 24.81% 22.81% -2.01%
- Complexity 1136 1232 +96
============================================
Files 132 146 +14
Lines 3469 3791 +322
============================================
+ Hits 861 865 +4
- Misses 2608 2926 +318 ☔ View full report in Codecov by Sentry. |
…F_SORT and TRAP_XHPROF_PATH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Added FileObserver that can find xhprof files in a directory configured in php.ini
Add envs:
TRAP_XHPROF_SORTTRAP_XHPROF_PATHDifference between algorithms:
Details
TRAP_XHPROF_SORT=0TRAP_XHPROF_SORT=1TRAP_XHPROF_SORT=2TRAP_XHPROF_SORT=3Checklist