fix(acp): populate authMethods, add /agent.json endpoint, eliminate IPI duplication#2431
Merged
fix(acp): populate authMethods, add /agent.json endpoint, eliminate IPI duplication#2431
Conversation
…PI duplication
- Populate InitializeResponse.auth_methods with [{type: agent, id: zeph}] using
the typed builder; previously returned authMethods: [] which blocked ACP Registry
inclusion (#2422)
- Serve GET /agent.json with agent identity manifest (id, name, version, description,
distribution) for ACP Registry discovery; gated on discovery_enabled (#2422)
- Extract apply_three_class_classifier_with_cfg and apply_causal_analyzer_with_cfg
helpers in agent_setup.rs; acp.rs now delegates instead of inlining construction
eliminating the DRY gap from #2369 (#2370)
- discovery.rs already reflects ProtocolVersion::LATEST since PR #2423 (#2412)
Closes #2422, closes #2370
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InitializeResponse.auth_methodswith[{type: "agent", id: "zeph", name: "Zeph"}]— previously returnedauthMethods: []which blocked ACP Registry inclusionGET /agent.jsonwith agent identity manifest (id,name,version,description,distribution) for ACP Registry discovery; gated ondiscovery_enabledapply_three_class_classifier_with_cfgandapply_causal_analyzer_with_cfghelpers inagent_setup.rs;spawn_acp_agentnow delegates to shared helpers eliminating the DRY gap from feat(security): IPI defense — DeBERTa soft-signal, three-class AlignSentinel, TurnCausalAnalyzer #2369discovery.rsalready reflectsProtocolVersion::LATESTsince PR feat(acp): update agent-client-protocol 0.10.2→0.10.3, schema 0.11.2→0.11.3 #2423 (confirmed, no code change)Closes #2422, closes #2370
Test plan
cargo +nightly fmt --checkpassescargo clippy --workspace -- -D warningspassescargo nextest run --workspace --lib --binspasses (6715 tests)cargo nextest run -p zeph-acp --lib --features acp-httppasses (322 tests)initialize_response_includes_agent_auth_method,agent_json_returns_expected_fields,agent_json_disabled_returns_404