feat(acp): implement session/close handler and capability advertisement#2429
Merged
feat(acp): implement session/close handler and capability advertisement#2429
Conversation
…nt (#2421) - Add `unstable-session-close` feature to zeph-acp, wired to `agent-client-protocol/unstable_session_close`; included in `acp-unstable` compound feature in root Cargo.toml - Implement `close_session` on `ZephAcpAgent`: removes session from LRU map and fires cancel signal to any running turn actor (idempotent for unknown session IDs) - Advertise `session: { close: {} }` in `initialize` response capabilities when feature is enabled - Add 3 new unit tests covering removal, idempotency, and cancel signal; update `initialize_advertises_session_capabilities` to assert `close.is_some()`
github-actions
bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2421
Summary
unstable-session-closefeature tozeph-acp, wired toagent-client-protocol/unstable_session_close; included inacp-unstablecompound feature in rootCargo.tomlclose_sessiononZephAcpAgent: removes the session from the LRU map and fires the cancel signal to any running turn actor; idempotent for unknown session IDssession: { close: {} }in theinitializeresponse capabilities when the feature is enabledclose_session_removes_entry,close_session_unknown_id_is_ok,close_session_signals_cancel) + updatedinitialize_advertises_session_capabilitiesTest plan
cargo +nightly fmt --checkpassescargo clippy --workspace --features full -- -D warningspasses (0 warnings)cargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 7265 passed--features unstable-session-close