Conversation
github-actions
bot
added
documentation
…tartup; migrate legacy bundled skills AgentBuilder gains with_two_stage_matching and with_confusability_threshold builder methods. Both are wired in runner.rs and daemon.rs alongside with_disambiguation_threshold, so config values are applied at startup rather than only after hot-reload. Closes #2404. provision_bundled_skills now detects legacy bundled skills (dirs without a .bundled marker whose SKILL.md content matches the embedded version) and re-provisions them, adding the marker and updated category field without overwriting user-modified skills. Closes #2403.
bug-ops
force-pushed
the
2404-skills-startup-wiring
branch
from
9a1a464 to
7a55aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
two_stage_matchingandconfusability_thresholdconfig fields are now applied at agent startup instead of only after hot-reload (AgentBuildergains two new builder methods; wired inrunner.rsanddaemon.rs).bundledmarker system are migrated on upgrade —provision_bundled_skillsdetects skills whoseSKILL.mdmatches the embedded version and re-provisions them with thecategoryfield and marker, without touching user-modified skillsChanges
crates/zeph-core/src/agent/builder.rs—with_two_stage_matchingandwith_confusability_thresholdbuilder methodssrc/runner.rs,src/daemon.rs— wire new builder methods alongsidewith_disambiguation_thresholdcrates/zeph-skills/src/bundled.rs—is_legacy_bundledhelper + migration inMarkerState::NoMarkerbranchTest plan
with_two_stage_matchingandwith_confusability_threshold(clamping, flag set/unset)provision_bundled_skillsmigration path: re-provision with markers removed → all skills updated; re-provision with modified SKILL.md → skippedcargo nextest run --config-file .github/nextest.toml --workspace --lib --bins— 6711 passedCloses #2404
Closes #2403