Conversation
github-actions
bot
added
documentation
This was
linked to
issues
Mar 29, 2026
…s, concurrent embeddings (#2362, #2364, #2365) - Split consolidation LLM prompt into Role::System (instructions) + Role::User (memory entries) to prevent adversarial content injection (#2362) - Add apply_consolidation_update: in-place UPDATE on target_id instead of duplicating apply_consolidation_merge; target_id is no longer ignored (#2364) - Replace sequential embed loop with futures::future::join_all for concurrent embedding in run_consolidation_sweep (#2365) - Update run_consolidation_sweep_update_db_state test for new in-place semantics - Add apply_consolidation_update_in_place and apply_consolidation_update_skips_below_threshold tests
bug-ops
force-pushed
the
2362-consolidation-prompt
branch
from
25160ad to
fcfccc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Role::System(instructions) +Role::User(memory entries) — prevents adversarial memory content from influencing consolidation decisionsTopologyOp::Updatenow performs an actual in-placeUPDATE messages SET content = ?ontarget_idinstead of re-usingapply_consolidation_merge;target_idwas previously ignored with..futures::future::join_allfor concurrent embedding — reduces latency for large batchesTest plan
cargo +nightly fmt --check— cleancargo clippy --all-targets --all-features --workspace -- -D warnings— 0 warningscargo nextest run --workspace --all-features --lib --bins— 7235 passed (+2 new tests)run_consolidation_sweep_update_db_stateto verify in-place semantics (no new row inserted, content changed on existing row)apply_consolidation_update_in_place— verifies same row ID with updated content, join table entry, source marked consolidated=1apply_consolidation_update_skips_below_threshold— verifies content unchanged when confidence < thresholdCloses #2362, #2364, #2365