audit(docker): add all missing ZEPH_* env vars to compose files#2382
Merged
audit(docker): add all missing ZEPH_* env vars to compose files#2382
Conversation
- Add 66 missing ZEPH_* vars (with empty defaults) to docker-compose.yml and docker-compose.dev.yml, grouped by category: bootstrap, LLM cache, vault secrets, memory, skills, tools, A2A, ACP, index, STT, timeouts, logging. ZEPH_AUTO_UPDATE_CHECK defaults to false in Docker. - Fix bug: rename ZEPH_MEMORY_SEMANTIC_RECALL_LIMIT to ZEPH_MEMORY_RECALL_LIMIT in both compose files (the SEMANTIC_ variant was silently ignored by crates/zeph-config/src/env.rs). - Add ZEPH_DATABASE_URL to docker-compose.dev.yml (was missing from dev). - Add scripts/check-env-vars.sh: drift-prevention script that compares ZEPH_* vars in env.rs against docker-compose.yml, exits 1 on drift. - Add PR template checklist item requiring docker/ update when env vars change. Closes #2375
github-actions
bot
added
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZEPH_*env vars (with empty defaults) todocker/docker-compose.ymlanddocker/docker-compose.dev.yml, grouped by category: bootstrap, LLM cache, vault secrets, memory, skills, tools, A2A, ACP, index, STT, timeouts, loggingZEPH_MEMORY_SEMANTIC_RECALL_LIMIT→ZEPH_MEMORY_RECALL_LIMITin both compose files (theSEMANTIC_variant was not recognized bycrates/zeph-config/src/env.rsand was silently ignored)ZEPH_DATABASE_URLtodocker-compose.dev.yml(was missing from dev, present in prod)scripts/check-env-vars.sh: drift-prevention script comparingZEPH_*vars inenv.rsagainstdocker-compose.yml, exits 1 on driftdocker/update when env vars changeCoverage before/after
Test plan
scripts/check-env-vars.shexits 0 (all vars covered)cargo +nightly fmt --checkpassescargo clippy --all-targets --all-features --workspace -- -D warningspasses (0 warnings)cargo nextest run --workspace --all-features --lib --binspasses (6608/6608)Closes #2375