Conversation
… CI postgres build - --init wizard: add database backend selection (sqlite/postgres); postgres branch prints vault instruction, writes empty placeholder, skips sqlite_path - --migrate-config: add migrate_database_url() step; injects commented-out database_url under [memory], creates section if absent, idempotent - zeph db migrate: new CLI subcommand; validates URL, connects and runs pending migrations, prints count; redacts credentials in error paths - CI: add build-postgres job (cargo check -p zeph-db --no-default-features --features postgres) to keep postgres build green - docker/docker-compose.yml: add ZEPH_DATABASE_URL env var
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--initwizard: new database backend selection step (sqlite/postgres); postgres branch prints vault instruction (zeph vault set ZEPH_DATABASE_URL), writes empty placeholder to config, skipssqlite_path--migrate-config: newmigrate_database_url()step injects commented-outdatabase_urlunder[memory]; handles missing section, idempotentzeph db migrate: new CLI subcommand that validates backend URL, connects, runs pending migrations, prints count; credentials redacted in all error pathsbuild-postgresjob:cargo check -p zeph-db --no-default-features --features postgres— keeps postgres feature flag buildabledocker/docker-compose.yml: addZEPH_DATABASE_URL: ${ZEPH_DATABASE_URL:-}Deferred
SqliteStorecall sites don't compile under--features postgres(full workspace)db.rshave no unit testsbuild_configpostgres path ininit.rshas no unit testZEPH_*env vars vs docker/ filesTest plan
cargo nextest run --workspace --lib --bins— 6608/6608 passcargo check -p zeph-db --no-default-features --features postgreszeph --init— verify postgres branch prompts correctly, no URL stored in configzeph --migrate-config— verify idempotent on second runzeph db migrate— verify prints migration count on fresh DB