feat(orchestration): activate VMAO verify-completeness in PlanVerifier#2346
Merged
feat(orchestration): activate VMAO verify-completeness in PlanVerifier#2346
Conversation
This was referenced Mar 28, 2026
#2252) Activate the existing PlanVerifier skeleton with per-task and whole-plan verification gates, a completeness_threshold config field, and a single-cycle gap-filling replan loop based on the VMAO paper (arXiv:2603.11445). - Add completeness_threshold: f32 (default 0.7) to OrchestrationConfig with sanitizer clamping to [0.0, 1.0] and startup validation - Add verify_plan() for whole-plan verification after DagScheduler completion - Add replan_from_plan() generating root TaskNodes for plan-level gaps - Wire SchedulerAction::Verify handler in agent loop (was a no-op since #2235) - Add whole-plan verification step between Done{Completed} and aggregation - Partial replan DAG runs in a separate DagScheduler with max_replans=0 and verify_completeness=false to prevent recursive loops (INV-2) - Partial DAG outputs merged with original task outputs before aggregation - Output truncated to verify_max_tokens*4 chars before verify_plan() call - GapSeverity implements Display returning lowercase names consistent with serde snake_case serialization and LLM system prompt expectations - All LLM error paths are fail-open: verify returns complete=true, replan returns empty Vec, whole-plan verify returns None - 25 new unit tests across verifier.rs and experiment.rs - verify_completeness = false by default; no behavior change when disabled Closes #2252
e4085e0 to
3cffd78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Activates the existing
PlanVerifierskeleton (introduced in PR #2235) with a full per-task and whole-plan verification pipeline based on the VMAO paper (arXiv:2603.11445). Whenverify_completeness = true, the agent now runs an LLM-judged completeness check after DAG execution and triggers a targeted gap-filling replan cycle for incomplete sub-tasks.completeness_threshold: f32(default 0.7) toOrchestrationConfigwith sanitizer clamping and startup validationverify_plan()for whole-plan verification afterDagSchedulercompletesreplan_from_plan()generating rootTaskNodes for plan-level gapsSchedulerAction::Verifyhandler in agent loop (was no-op since feat(orchestration): AdaptOrch topology-routing and Plan-Execute-Verify-Replan (#2219, #2202) #2235)Done{Completed}and aggregationDagSchedulerwithmax_replans=0andverify_completeness=false(INV-2: no recursive loops)Aggregatorverify_max_tokens * 4chars beforeverify_plan()callGapSeverityimplementsDisplayreturning lowercase names consistent with serdesnake_caseand LLM system prompt expectationsverifier.rsandexperiment.rsverify_completeness = falseby default — no behavior change when disabledCloses #2252
Research evaluations (in architect handoff
.local/handoff/2026-03-28T10-59-52-architect.yaml)TopologyClassifieralready exists; content-aware topology routing needs a feedback loop that VMAO completeness scores can now provideTest plan
cargo +nightly fmt --check— passedcargo clippy --workspace --features full -- -D warnings— 0 warningscargo nextest run --workspace --features experiments --lib --bins— 6581/6581 passedverify_completeness = false(default) produces no behavior changecompleteness_thresholdoutside [0.0, 1.0] rejected at startup