fix(mcp): wire EmbeddingAnomalyGuard into McpManager#2336
Merged
Conversation
github-actions
bot
added
bug
bug-ops
force-pushed
the
2331-wire-embedding-anomaly-guard
branch
from
4d08f18 to
44da55c
Compare
Add with_embedding_guard() builder to McpManager following the same pattern as with_prober()/with_trust_store(). Hook call_tool() to call guard.check_async() fire-and-forget after every successful tool call. Wire the guard in build_tool_setup() when security.content_isolation.embedding_guard.enabled = true. Spawn a background drain task that logs Anomalous and injection-detected RegexFallback events at warn level. Annotate AnyProvider::embed_fn() return type with + use<> to prevent lifetime overcapture under Edition 2024. Closes #2331
bug-ops
force-pushed
the
2331-wire-embedding-anomaly-guard
branch
from
a347be4 to
c3cce75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
with_embedding_guard()builder toMcpManager(same pattern aswith_prober()/with_trust_store())call_tool()to callguard.check_async()fire-and-forget after every successful MCP tool callbuild_tool_setup()whensecurity.content_isolation.embedding_guard.enabled = trueAnomalousand regex-injectionRegexFallbackevents atwarn!levelAnyProvider::embed_fn()return type with+ use<>to prevent Edition 2024 lifetime overcaptureCloses #2331
Test plan
cargo build --workspace --features full— cleancargo +nightly fmt --check— cleancargo clippy --all-features --workspace -- -D warnings(changed crates) — cleancargo nextest run --workspace --all-features --lib --bins— 6927/6927 passed