Conversation
github-actions
bot
added
documentation
…ix stale delta, add ema_floor validation (#2315, #2323, #2322) - Wire DefaultMcpProber and TrustScoreStore into agent bootstrap via wire_trust_calibration(); respects trust_calibration.enabled and probe_on_connect config flags (#2315) - Add TrustScoreStore::load_and_apply_delta() to apply time-decay before writing score delta; replace raw apply_delta() at both manager.rs call sites (#2323) - Add validate_embedding_threshold and validate_min_samples custom deserializers to EmbeddingGuardConfig; reject threshold outside (0.0,1.0] and min_samples == 0 (#2322) - EmbeddingAnomalyGuard bootstrap wiring deferred: McpManager has no with_embedding_guard() API; tracked as follow-up
bug-ops
force-pushed
the
fix/2315-mcp-prober-bootstrap-wiring
branch
from
edf8a9c to
9cc6de1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultMcpProberandTrustScoreStoreinto agent bootstrap viawire_trust_calibration(); respectstrust_calibration.enabledandprobe_on_connectconfig flags (closes fix(mcp): DefaultMcpProber, TrustScoreStore, and EmbeddingAnomalyGuard not wired into agent bootstrap #2315)TrustScoreStore::load_and_apply_delta()to apply time-decay before writing score delta; replace rawapply_delta()at bothmanager.rscall sites (closes fix(mcp): apply_delta() in probe paths operates on stale pre-decay score (load-before-delta gap) #2323)validate_embedding_thresholdandvalidate_min_samplescustom deserializers toEmbeddingGuardConfig; rejectthresholdoutside(0.0, 1.0]andmin_samples == 0(closes fix(mcp): add bounds validation for ema_floor config field in EmbeddingGuardConfig #2322)EmbeddingAnomalyGuardbootstrap wiring is deferred —McpManagerhas nowith_embedding_guard()API; a follow-up issue will be filed.Test plan
cargo +nightly fmt --check— passescargo clippy --workspace -- -D warnings— passes (0 warnings)cargo nextest run --workspace --lib --bins— 6396 passed, 15 skippedtrust_calibration.enabled = trueandprobe_on_connect = true: prober and trust store wired at connectembedding_guard.threshold = 0.0: deserialization error returnedembedding_guard.threshold = 1.5: deserialization error returned