fix(memory): eliminate 255 redundant BPE loads in proptest#2327
Merged
Conversation
count_tokens_never_panics called TokenCounter::new() inside the proptest body, constructing and parsing the tiktoken cl100k_base BPE vocabulary (~1 MB, ~100k HashMap entries) on every one of the 256 proptest cases. Replace with a LazyLock static so the TokenCounter is initialized once per test binary execution, matching how the production agent uses it. Also add slow-timeout = 30s warning to the ci-partition nextest profile as a safety net to surface future slow tests in CI output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
count_tokens_never_panicscalledTokenCounter::new()inside the proptest body. Each call toTokenCounter::new()parses the tiktokencl100k_baseBPE vocabulary (~1 MB, ~100kHashMapentries). With 256 proptest cases, this resulted in 256 full BPE HashMap constructions per test run instead of one.The
cl100k_basesingleton exists in production code exactly to avoid this, but the test bypassed it.Fix
Use a
LazyLockstatic so theTokenCounteris initialized once per test binary execution — matching how the production agent uses it (one counter per session).Result
Test runtime: ~several seconds → 0.204s (measured locally).
Bonus
Add
slow-timeout = { period = "30s" }warning override to theci-partitionnextest profile as a safety net — nextest prints a warning if any test exceeds 30s without failing the run, surfacing future regressions early.