fix(tools): quote cwd path in sandbox_allows_cwd_by_default test#2282
Merged
fix(tools): quote cwd path in sandbox_allows_cwd_by_default test#2282
Conversation
github-actions
bot
added
rust
bug-ops
force-pushed
the
2279-sandbox-spaces-false-positive
branch
from
d212796 to
5d4e08f
Compare
Paths with spaces (e.g. macOS user directories) were passed unquoted to the shell command string, causing extract_paths() to split the path on whitespace and produce fragments that fail the sandbox prefix check. Quote the path in the test to match real shell usage, making the test portable on macOS and any system where the working directory contains spaces. Fixes #2279.
bug-ops
force-pushed
the
2279-sandbox-spaces-false-positive
branch
from
5d4e08f to
0582a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandbox_allows_cwd_by_defaulttest failure on macOS systems where the home directory path contains spaces (e.g.Documents - rabax's MacBook Pro)extract_paths()tokenized by splitting on whitespace — producing path fragments that failed the sandboxstarts_withcheck"cat \"{path}/file.txt\"") to match real shell usage, where paths with spaces must be quotedTest plan
cargo nextest run -p zeph-tools -E 'test(sandbox_allows_cwd_by_default)'passescargo nextest run -p zeph-tools --lib --bins— 852/852 passedCloses #2279