fix(skills): suppress false-positive injection WARN for bundled skills#2273
Merged
fix(skills): suppress false-positive injection WARN for bundled skills#2273
Conversation
github-actions
bot
added
documentation
#2272) Bundled skills are vetted at build time and may contain security-awareness text that mentions injection patterns (e.g. browser/SKILL.md warns about "ignore previous instructions"). The content scanner was flagging these as potential injection attempts on every startup, causing alert fatigue and masking real findings. Now scan_loaded() checks for the .bundled marker file in the skill directory. If present, pattern matches are logged at DEBUG instead of WARN and excluded from the returned findings list. User-installed skills (no .bundled marker) continue to produce WARN as before.
bug-ops
force-pushed
the
2272-bundled-skill-scan-warn
branch
from
fd3d5da to
7277afa
Compare
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2272.
Summary
scan_loaded()inSkillRegistrynow checks for a.bundledmarker file in the skill directory before emitting aWARNDEBUGand excluded from the returned findings list.bundledmarker) continue to produceWARNas beforeTest plan
cargo nextest run -p zeph-skills --lib— 260 tests pass (includes 2 new tests)cargo nextest run --workspace --features full --lib --bins— 6818 tests passcargo clippy --profile ci --workspace --features full -- -D warnings— cleancargo +nightly fmt --check— clean