fix(skills): include managed_dir in build_registry and wire FaultCategory enum path#2265
Merged
fix(skills): include managed_dir in build_registry and wire FaultCategory enum path#2265
Conversation
github-actions
bot
added
bug
bug-ops
force-pushed
the
2259-skills-build-registry
branch
from
c6156cd to
c73daf2
Compare
…gory path - build_registry() now calls self.skill_paths() instead of building the path list from config.skills.paths directly; ensures managed_dir is always included so bundled skills are matched even when skills.paths is customized (#2259) - native.rs: capture ToolErrorCategory in the Err arm and propagate it via tool_err_category to the skill outcome recording; replaces the string heuristic FailureKind::from_error with enum-accurate FailureKind::from(category) (#2224) - legacy.rs: extract category = e.category() before consuming e with format!, then use FailureKind::from(category) in handle_tool_result Err branch (#2224)
bug-ops
force-pushed
the
2259-skills-build-registry
branch
from
c73daf2 to
73446e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_registry()now callsself.skill_paths()which includesmanaged_dir; fixes silent loss of all bundled skills whenskills.pathsis customized in config (fix(skills): build_registry() does not include managed_dir — bundled skills not matched when skills.paths is customized #2259)FaultCategoryenum path innative.rsandlegacy.rsto replace string-heuristicFailureKind::from_error()with enum-accurateFailureKind::from(category)for skill evolution signals (feat(reliability): wire FaultCategory enum path in native.rs Err branch for skill evolution #2224)Changes
crates/zeph-core/src/bootstrap/mod.rsbuild_registry(): replaced inlineself.config.skills.pathscollection withself.skill_paths()(which already deduplicates and appendsmanaged_dir)crates/zeph-core/src/agent/tool_execution/native.rstool_err_category: Option<ToolErrorCategory>before the result match loopErr(ref e)arm frome.category()tool_err_category.take().map_or_else(|| FailureKind::from_error(&output), FailureKind::from)crates/zeph-core/src/agent/tool_execution/legacy.rshandle_tool_resultErr(e)arm: extractcategory = e.category()before consumingewithformat!, then useFailureKind::from(category)process_successful_tool_outputunchanged (noToolErrorin scope)Test plan
cargo +nightly fmt --check— cleancargo clippy -p zeph-core -p zeph-skills -- -D warnings— cleancargo nextest run -p zeph-core -p zeph-skills --lib --bins— 1419/1419 passedCloses #2259
Closes #2224