Conversation
… LevelBarrier dispatch Adds 7 inline #[cfg(test)] tests to scheduler.rs covering the two missing test areas identified in #2241 and #2242: inject_tasks replan caps (#2241): - per-task cap: second inject for same task_id is a silent no-op - global cap: second inject after max_replans exhausted is a silent no-op - topology_dirty flag is set by inject_tasks and cleared by the next tick() - cycle detection: self-referencing injected task returns VerificationFailed LevelBarrier dispatch (#2242): - level advance: current_level increments when all tasks at that level are terminal - transitive failure propagation: Skip strategy BFS-marks all descendants Skipped - current_level reset: tick() resets current_level down via .min() after inject_tasks adds a task at depth < current_level Closes #2241, closes #2242
github-actions
bot
added
documentation
github-actions
bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inject_tasks()replan caps (test(orchestration): add DagScheduler integration tests for inject_tasks() replan caps #2241): per-task cap silent no-op, global cap enforcement,topology_dirtyflag lifecycle, cycle rejection viaVerificationFailedLevelBarrierdispatch (test(orchestration): add DagScheduler integration tests for LevelBarrier dispatch #2242): level advance on terminal tasks, transitive failure propagation (Skip BFS),current_levelreset afterinject_tasks()inserts at depth < current levelAll tests are inline
#[cfg(test)]incrates/zeph-orchestration/src/scheduler.rs. 249 tests in the crate pass (was 242).Test plan
cargo nextest run -p zeph-orchestration --lib— 249 passedcargo +nightly fmt --check— cleancargo clippy -p zeph-orchestration --all-features -- -D warnings— cleancargo nextest run --workspace --lib --bins— 6253 passedCloses #2241, closes #2242