Skip to content

fix(llm): add missing MessageMetadata import in candle_provider test module (#2189)#2195

Merged
bug-ops merged 1 commit intomainfrom
2189-candle-messagemetadata
Mar 27, 2026
Merged

fix(llm): add missing MessageMetadata import in candle_provider test module (#2189)#2195
bug-ops merged 1 commit intomainfrom
2189-candle-messagemetadata

Conversation

@bug-ops
Copy link
Copy Markdown
Owner

@bug-ops bug-ops commented Mar 27, 2026

Summary

  • Adds use crate::provider::MessageMetadata; inside #[cfg(test)] mod tests in crates/zeph-llm/src/candle_provider/template.rs
  • MessageMetadata was used in sample_messages() helper but never imported, causing --features candle alone to fail compilation

Root Cause

template.rs imports only Message and Role at the module level. The test module's use super::* does not pull in MessageMetadata since it was not in scope. --features full masks this because all features are enabled together.

Test Plan

  • cargo nextest run -p zeph-llm --features candle --lib — 812/812 passed (was failing before fix)
  • cargo nextest run --workspace --features full --lib --bins — 6554/6554 passed
  • cargo +nightly fmt --check — clean
  • cargo clippy --all-targets --features full --workspace -- -D warnings — no new warnings

Closes #2189

…module (#2189)

`--features candle` alone failed to compile because `MessageMetadata`
was used in the test module of `template.rs` without being imported.
Added `use crate::provider::MessageMetadata` inside `#[cfg(test)]`.

Fixes #2189.
@github-actions github-actions bot added bug Something isn't working documentation Improvements or additions to documentation llm zeph-llm crate (Ollama, Claude) rust Rust code changes size/XS Extra small PR (1-10 lines) and removed bug Something isn't working labels Mar 27, 2026
@bug-ops bug-ops enabled auto-merge (squash) March 27, 2026 01:33
@bug-ops bug-ops merged commit c48d1a2 into main Mar 27, 2026
25 checks passed
@bug-ops bug-ops deleted the 2189-candle-messagemetadata branch March 27, 2026 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation llm zeph-llm crate (Ollama, Claude) rust Rust code changes size/XS Extra small PR (1-10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(candle): --features candle alone fails to compile (MessageMetadata unresolved)

1 participant