feat(orchestration): add planner_provider field to OrchestrationConfig#2184
Merged
feat(orchestration): add planner_provider field to OrchestrationConfig#2184
Conversation
#2172) Follow-up to #2183 per multi-model design principle: LlmPlanner now accepts a dedicated provider reference instead of always using the primary provider. Config field `planner_provider = "fast"` in `[orchestration]` references a `[[llm.providers]]` entry by name; empty string falls back to the primary provider. Field replaces the dead `planner_model: Option<String>` (never wired, pre-v1.0.0 removal). `build_planner_provider()` in bootstrap resolves the named provider and passes it to `LlmPlanner::new()` at all three wiring sites (daemon, runner, acp). `OrchestrationState.planner_provider` holds the optional resolved provider, scoped to orchestration rather than the global ProviderState. `migrate_planner_model_to_provider()` auto-migration step comments out any existing `planner_model` value with a MIGRATED marker so users know to supply a provider name instead of a model name. Also adds latency-threshold doc comment on `TopologyClassifier::suggest_max_parallel` (parallel scheduling overhead only pays off when individual tool calls take >= 500ms; for LLM API calls this is always satisfied; for local tools such as file reads, consider keeping topology_selection disabled). +50 tests (6504 -> 6554).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2183 per multi-model design requirement in #2172 (project owner comment).
planner_provider: Stringto[orchestration]config — references a[[llm.providers]]entry by name; empty = primary provider fallbackplanner_model: Option<String>field (never wired, pre-v1.0.0 clean removal)OrchestrationState→LlmPlanner::new()at all 3 sites (daemon, runner, acp)migrate_planner_model_to_provider()auto-migration step comments out oldplanner_modelvalue with MIGRATED markerTopologyClassifier::suggest_max_parallel(m13v insight: >= 500ms threshold for parallel overhead payoff)Breaking Changes
planner_modelconfig field removed; runzeph --migrate-config --in-placeto auto-convertTest plan
migrate_planner_model_to_providerwith field present and no-op casebuild_planner_providerfallback paths covered via integration fixtureCloses #2172