Conversation
github-actions
bot
added
tests
… PlanCacheConfig Add a unit test asserting that `similarity_threshold = 1.1` returns a validation error from `PlanCacheConfig::validate()`, covering the `similarity_threshold > 1.0` rejection path that was previously untested. Closes #2095
bug-ops
force-pushed
the
feat-issue-2095-tier-config-similarity-threshold
branch
from
8da1604 to
041ada0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
similarity_threshold > 1.0rejection path inPlanCacheConfig::validate()that was previously uncoveredsimilarity_threshold = 1.1and asserts the call returns an errorTest plan
cargo nextest run -p zeph-config --lib— 41 tests passcargo nextest run --workspace --features full --lib --bins— 6300 tests pass (+1)cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— cleanCloses #2095