Conversation
…#2023) - validate_context() evaluates 4 rules (ObjectiveNonEmpty, CriteriaPresent, HandoffRefSupported, RoleContextComplete) covering all 6 RoleContext variants; hard violations block dispatch, soft violations log warnings - verify_output() checks criteria coverage and Fail status, returns ValidationResult list; derive_verification_status() converts to VerificationStatus enum - DagScheduler::tick(): blocks dispatch on hard validation failures (task -> Failed + failure propagation), logs soft warnings, tracks per-rule violation counts in HandoffMetrics - DagScheduler::process_event(): runs verify_output() post-completion, updates HandoffMetrics (total_dispatched, clean/warned/blocked dispatches, verified/partial/failed/unverified completions, role_counts, rule_violations) - build_task_prompt(): uses structured DependencyOutput summaries from handoff_context when available, falls back to raw result injection - OrchestrationMetrics: 4 new handoff quality counters for TUI (handoff_validation_pass/fail, handoff_verification_pass/fail) - 26 new unit tests (6290 total, +26 vs Phase 1)
Resolves CHANGELOG.md conflict by keeping both entries. No code conflicts — changes are in disjoint crates.
…ssue #2023) - handoff.rs: 3 RoleContextComplete hard-fail tests for Tester (empty test_plan), Critic (empty review_dimensions), Reviewer (empty artifact_refs) - scheduler.rs: integration test for hard-fail blocking dispatch — verifies no Spawn produced, task.status=Failed, blocked_dispatches=1, rule_violations["ObjectiveNonEmpty"]=1 - scheduler.rs: integration test for soft-warn path — verifies Spawn proceeds, warned_dispatches=1, blocked_dispatches=0 6312 tests total (+5 vs previous commit)
github-actions
bot
added
documentation
bug-ops
added a commit
that referenced
this pull request
Mar 21, 2026
, #2078) The typed HandoffContext enum, RoleContext variants, and validation layer introduced in #2076 and #2078 are superseded by the rust-agent-handoff skill. Agents follow the handoff protocol via skill instructions injected into their system prompt — no compile-time struct enforcement is needed. Reverts: - handoff.rs (deleted) - typed HandoffConfig in zeph-config - handoff fields in TaskResult/TaskNode - handoff validation metrics in OrchestrationMetrics - scheduler.rs validation/verification wiring Closes #2023
2 tasks
bug-ops
added a commit
that referenced
this pull request
Mar 21, 2026
, #2078) (#2082) The typed HandoffContext enum, RoleContext variants, and validation layer introduced in #2076 and #2078 are superseded by the rust-agent-handoff skill. Agents follow the handoff protocol via skill instructions injected into their system prompt — no compile-time struct enforcement is needed. Reverts: - handoff.rs (deleted) - typed HandoffConfig in zeph-config - handoff fields in TaskResult/TaskNode - handoff validation metrics in OrchestrationMetrics - scheduler.rs validation/verification wiring Closes #2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 handoff validation layer for MAST-informed multi-agent coordination hardening.
Validation Rules
All rules produce actionable error messages with field-paths.
Test Coverage
Commits
Validators (Approved)
Known Limitation
OrchestrationMetrics.handoff_validation_pass/failandhandoff_verification_pass/failare defined but not wired fromDagScheduler.handoff_metrics(). Phase 3 follow-up to bridge metrics into TUI dashboard.Closes #2023