Conversation
…#1967 Add zeph-common as zeph-core dependency, delete duplicate text.rs, re-export via pub use zeph_common::text so existing crate::text:: paths remain valid.
…esitter' feature — closes #1968 Add zeph-common::treesitter module with 5 shared symbol query constants (RUST/PYTHON/JS/TS/GO_SYM_Q), compile_query helper, and lang_for_ext. Feature-gated behind 'treesitter'. zeph-tools and zeph-index now import from zeph-common::treesitter instead of maintaining their own copies. Lang enum and method queries remain in zeph-index.
…e rate_limiter into RuntimeConfig — closes #1971 Add FeedbackState { detector, judge } grouping feedback_detector and judge_detector. Move rate_limiter into RuntimeConfig alongside other runtime policy fields. Update all ~30 call sites across mod.rs, builder.rs, and tool_execution/native.rs.
…1970 Add agent/state/tests.rs with construction and field access tests for InstructionState, ExperimentState, MessageState, SessionState, RuntimeConfig (including rate_limiter), FeedbackState, and CompressionState (#[cfg(feature = "context-compression")]). ExperimentState has cfg-gated field tests behind #[cfg(feature = "experiments")]. Tests pass both without extra features (1940 tests) and with experiments,context-compression (2098 tests).
This was
linked to
issues
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Batch refactoring to address 5 follow-up issues from PR #1966 (structural code organization):
refactor: consolidate truncate_chars between zeph-core and zeph-common #1967 — Consolidate
truncate_charsduplication between zeph-core and zeph-commonpub use zeph_common::textrefactor: reduce tree-sitter query duplication between zeph-tools and zeph-index #1968 — Reduce tree-sitter query duplication between zeph-tools and zeph-index
treesitterfeature to avoid heavy depschore: add missing README.md for zeph-common crate #1969 — Add missing README.md for zeph-common crate
refactor: group remaining loose Agent fields into sub-structs #1971 — Group remaining loose Agent fields into sub-structs
refactor: add unit tests for agent state sub-structs #1970 — Add unit tests for agent state sub-structs
Test Results
Implementation Notes