fix(llm): OpenAI API 400 Bad Request on skill documentation#1955
Merged
fix(llm): OpenAI API 400 Bad Request on skill documentation#1955
Conversation
OpenAI API rejects assistant messages with tool_calls when content is ""
(empty string). Changed StructuredApiMessage.content from String to
Option<String> with skip_serializing_if, so tool-only assistant messages
emit content: null (or omit the field), matching the API requirement.
Also changed arguments fallback from unwrap_or_default() ("") to
unwrap_or_else(|_| "{}") so a serialization failure never produces an
invalid empty string.
Closes #1952
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HTTP 400 Bad Request from OpenAI API when querying skills documentation. Root cause:
StructuredApiMessage.contentserializes empty string""alongsidetool_calls, but OpenAI requiresnull/absent for this combination.Changes
StructuredApiMessage.content:String→Option<String>with#[serde(skip_serializing_if = "Option::is_none")]convert_messages_structured: emitNonewhen assistant text is emptyargumentsfallback:unwrap_or_default()→unwrap_or_else(|_| "{}".to_owned())convert_messages_structured_assistant_tool_only_content_is_noneTesting
Related
Closes #1952