fix(config): add XDG fallback to resolve_config_path for ACP IDE launch context#1947
Merged
fix(config): add XDG fallback to resolve_config_path for ACP IDE launch context#1947
Conversation
Extend the config resolution chain from 3 to 4 steps: 1. --config CLI flag (unchanged) 2. ZEPH_CONFIG env var (unchanged) 3. config/default.toml relative to CWD (only when the file exists) 4. ~/.config/zeph/config.toml XDG fallback (always returned as final default) Each step emits a tracing::debug! message indicating the resolution path. Add unit tests covering all four branches without unsafe set_var usage. Closes #1945
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_config_path()from 3 to 4 resolution steps: CLI flag →ZEPH_CONFIGenv →config/default.toml(CWD, if exists) →~/.config/zeph/config.toml(XDG fallback)tracing::debug!emitted at each step with resolved path and sourceget_envclosure (noset_var, no side effects)Fixes #1945
Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— 0 warningscargo nextest run --workspace --features full --lib --bins— 6121/6121 passedresolve_config_path_cli_overrideandresolve_config_path_defaulttests inbootstrap/tests.rsstill pass