fix(tui): implement send_tool_start in TuiChannel (#1931)#1935
Merged
Conversation
- Add send_tool_start() to TuiChannel: extracts command from params (command/path/url keys) with tool_name as fallback, emits AgentEvent::ToolStart - handle_tool_output_event: append output content when finalizing a streaming tool message so native tool calls show their output in TUI - Add two unit tests for send_tool_start in channel.rs
github-actions
bot
added
bug
Resolve CHANGELOG.md conflict — both fix entries retained.
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_tool_start()override toTuiChannelincrates/zeph-tui/src/channel.rs— extracts a human-readable command string from tool params (command/path/urlkeys, falling back totool_name) and emitsAgentEvent::ToolStartso the TUI shows tool name + spinner immediately on invocationhandle_tool_output_event()incrates/zeph-tui/src/app.rs— append output content to the existing streaming ToolStart message before finalizing it; retain legacy fallback branch for any edge cases where no prior ToolStart existsCloses #1931.
Test plan
cargo +nightly fmt --check— PASScargo clippy --workspace --features full -- -D warnings— PASScargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 6100 passedchannel.rscovering param extraction and tool_name fallback