fix(tui): clear graph spinner after spawn_graph_extraction#1926
Merged
Conversation
github-actions
bot
added
documentation
The "saving to graph..." status was set before spawning the background
extraction task but never cleared, leaving the TUI spinner visible
indefinitely. Add send_status("") immediately after the fire-and-forget
spawn to reset the status bar.
Also rename the status message from "extracting graph..." to
"saving to graph..." to better reflect that the work is async.
Closes #1924
bug-ops
force-pushed
the
1924-graph-spinner-cleared
branch
from
c0a9961 to
501e479
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The TUI status bar shows
saving to graph...spinner indefinitely after each turn where graph extraction is triggered. The spinner was never cleared becausespawn_graph_extraction()is fire-and-forget and returns immediately.Fix
Add
let _ = self.channel.send_status("").await;immediately afterspawn_graph_extraction()inmaybe_spawn_graph_extraction(). Also rename the status message from"extracting graph..."to"saving to graph..."to better reflect the async/background nature of the operation.Changes
crates/zeph-core/src/agent/persistence.rs: +2 lines, 2-line diffTest plan
cargo +nightly fmt --check— PASScargo clippy --workspace --features full -- -D warnings— PASScargo nextest run --workspace --features full --lib --bins— PASS (6053 passed)Closes #1924