sec: CodeQL cleartext-logging suppressions and Actions SHA pinning#1908
Merged
sec: CodeQL cleartext-logging suppressions and Actions SHA pinning#1908
Conversation
…s SHAs Add `// lgtm[rust/cleartext-logging]` suppression comments to 11 intentional debug/trace log sites that CodeQL incorrectly flags as sensitive data leaks (closes #1905). Pin all GitHub Actions in ci.yml and release.yml to full immutable commit SHAs to prevent supply chain attacks (closes #1906).
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust/cleartext-loggingfalse positives on 11 intentional debug/trace log sites with// lgtm[rust/cleartext-logging]inline comments (closes sec: suppress CodeQL cleartext-logging false positives #1905)ci.ymlandrelease.ymlto full immutable commit SHAs with version tag comments (closes sec: pin GitHub Actions to full commit SHA #1906)Changes
// lgtm[rust/cleartext-logging]suppression comments.github/workflows/ci.yml: all action tags replaced with full SHAs.github/workflows/release.yml: all action tags replaced with full SHAsCHANGELOG.md: Security section added to [Unreleased]Checks
cargo +nightly fmt --check: passcargo clippy --workspace --features full -- -D warnings: pass (0 warnings)cargo nextest run --workspace --features full --lib --bins: 6043 passed, 12 skipped, 0 failed