feat(tools): add --init wizard step for pre-execution verifier config (#1880)#1897
Merged
feat(tools): add --init wizard step for pre-execution verifier config (#1880)#1897
Conversation
github-actions
bot
added
enhancement
…#1880) Add a new step to the interactive --init wizard that configures the [security.pre_execution_verify] section: - Confirm prompt to enable/disable pre-execution verification (default: yes) - Informational line showing the default shell tools list (bash, shell, terminal) - Optional comma-separated allowed paths input for DestructiveCommandVerifier (empty = deny all destructive commands, which is the secure default) - Whitespace trimming on each path segment - Build config mapping to SecurityConfig.pre_execution_verify Closes #1880
bug-ops
force-pushed
the
feat-tools-add-init-wizard-ste
branch
from
5da01fc to
ea06bb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--initinteractive wizard for configuring[security.pre_execution_verify]bash,shell,terminal) as informational contextDestructiveCommandVerifier(empty = deny all)Closes #1880
Changes
src/init.rs: +2 fields inWizardState, new prompts instep_security(),build_config()mapping, 4 new testsdocs/src/getting-started/wizard.md: Step 16 — Security section updatedCHANGELOG.md: entry in[Unreleased]Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— 0 warningscargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 6004 passedbuild_config_pre_execution_verify_enabled_default,build_config_pre_execution_verify_disabled,build_config_pre_execution_verify_allowed_paths,build_config_pre_execution_verify_empty_paths