fix(policy): remove dead PolicyEffect::AllowIf variant#1883
Merged
Conversation
The variant was declared in PR #1870 but evaluated identically to Allow in the policy engine (deny-wins check: `rule.effect != Deny`). This made it misleading for users writing TOML policy rules. Remove AllowIf and update the inline comment in the evaluator. Conditions on allow rules are already expressed via rule fields (tool_matcher, params, trust, etc.) — no separate variant is needed. Closes #1871
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PolicyEffect::AllowIffromcrates/zeph-tools/src/policy.rs— the variant was introduced in PR feat(security): declarative policy compiler for tool call authorization #1870 but evaluated identically toAllowin the policy engine (deny-wins loop usesrule.effect != PolicyEffect::Deny)evaluate()from "allow/allow_if" to "allow"CHANGELOG.mdunder[Unreleased]Test plan
cargo +nightly fmt --check— passedcargo clippy --workspace --features full -- -D warnings— 0 warningscargo nextest run --workspace --features full --lib --bins— 5968 passedCloses #1871