feat(memory): add --compression-guidelines CLI flag#1844
Merged
Conversation
github-actions
bot
added
enhancement
Add `--compression-guidelines` boolean flag to CLI that overrides `config.memory.compression_guidelines.enabled = true` at startup. Follows the existing `--graph-memory` pattern: plain clap bool field, config override in runner.rs, feature gate is on the spawn block only so the flag is safe to pass without the feature compiled in. Also add build_config tests for the wizard compression_guidelines path in src/init.rs, parallel to the existing graph_memory tests.
bug-ops
force-pushed
the
add-compression-guidelines-cli
branch
from
63c99c1 to
795580f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--compression-guidelinesboolean CLI flag to overrideconfig.memory.compression_guidelines.enabled = trueat startup--graph-memorypattern: plain clap bool insrc/cli.rs, config override insrc/runner.rscompression-guidelines) remains only on the spawn block — passing the flag without the feature compiled in is harmless (silent no-op)build_configtests for wizardcompression_guidelines_enabledpath insrc/init.rs, parallel to existinggraph_memorytestsCloses #1802.
Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— cleancargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5832 passed