fix(llm): strip URL path in parse_host_port for Ollama base_url with /v1 suffix#1837
Merged
fix(llm): strip URL path in parse_host_port for Ollama base_url with /v1 suffix#1837
Conversation
…/v1 suffix Resolves #1832. parse_host_port() now uses url::Url::parse() to extract host and port, discarding any path/query/fragment. A fallback rfind(':') path is retained for bare "host:port" strings without a scheme. Adds 8 unit tests covering: plain host, host+port, path suffix, https, trailing slash, IPv6 with port, IPv6 without port, bare host:port.
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1832.
Problem
parse_host_port()usedrfind(':')to split host and port. Whenbase_urlcontains a path component (e.g.http://localhost:11434/v1),port_strbecomes"11434/v1"which cannot parse asu16. The fallback then returns the full URL string as the host, causing API URLs likehttp://localhost:11434/v1api/embed→ HTTP 404.Fix
Replace the
rfind-based heuristic withurl::Url::parse(), which correctly extracts scheme, host, and port while discarding path/query/fragment. A fallbackrfind(':')path is retained for bare"host:port"strings without a scheme (guarded behind a scheme-presence check).IPv6 addresses are handled via
url::Host::Ipv6match to preserve brackets in the reconstructed URL.Tests
8 unit tests added to
parse_host_port:Checklist
cargo +nightly fmt --checkpassescargo clippy --workspace --features full -- -D warningspassescargo nextest run --workspace --features full --lib --binspasses (5801 tests)