Conversation
…onversation scoping Adds migration 034 with ALTER TABLE to add nullable conversation_id column (FK to conversations with CASCADE delete) to compression_guidelines table. Updates load_compression_guidelines to accept Option<ConversationId>: - Some(cid): returns conversation-specific guidelines (preferred) + global fallback - None: returns only global guidelines Updates save_compression_guidelines to accept and bind conversation_id. Summarization path passes self.memory_state.conversation_id; background updater uses None (global scope). Version numbers remain globally sequential. Closes #1806
github-actions
bot
added
documentation
…034_summaries_nullable_message_ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1806.
Adds
conversation_idcolumn to thecompression_guidelinestable via a new migration (034), enabling per-conversation scoping of ACON compression guidelines.034_compression_guidelines_conversation_id.sql:ALTER TABLE compression_guidelines ADD COLUMN conversation_id INTEGER REFERENCES conversations(id) ON DELETE CASCADE+ indexload_compression_guidelines(conversation_id: Option<ConversationId>): whenSome(cid), returns conversation-specific guidelines (preferred) with global fallback; whenNone, returns only global guidelinessave_compression_guidelinesaccepts optionalconversation_id— background updater passesNone(global scope), summarization path passes per-conversation idUNIQUE(version)constraint preserved)Test plan
cargo +nightly fmt --check— cleancargo clippy --workspace --features full -- -D warnings— 0 warningscargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5799 passed, 12 skipped