fix(core): restore JIT tool reference injection after overflow SQLite migration#1826
Merged
fix(core): restore JIT tool reference injection after overflow SQLite migration#1826
Conversation
… migration
OVERFLOW_NOTICE_PREFIX was pointing to the old file-path format
('[full output saved to') while the actual overflow notice format
changed in PR #1782 to '[full output stored as overflow:{uuid}'.
As a result, extract_overflow_ref() always returned None and the JIT
reference was never injected into pruned tool outputs.
- Update OVERFLOW_NOTICE_PREFIX to match current SQLite overflow format
- Update extract_overflow_ref() doc comment (UUID instead of path)
- Update all five JIT reference sites to emit
'[tool output pruned; use read_overflow {uuid} to retrieve]'
- Update tests in summarization.rs and context/mod.rs to use new format
Closes #1818
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OVERFLOW_NOTICE_PREFIXpointed to the old file-path format ([full output saved to) while PR feat(core): migrate tool overflow storage from disk to SQLite #1782 changed the actual notice to[full output stored as overflow:{uuid}— causingextract_overflow_ref()to always returnNoneand JIT references to never be injectedOVERFLOW_NOTICE_PREFIXand its doc comment to match the current SQLite format[tool output pruned; use read_overflow {uuid} to retrieve]so the agent can callread_overflow {uuid}to recover pruned contentsummarization.rsandcontext/mod.rsto use the new UUID-based formatTest plan
cargo +nightly fmt --checkpassescargo clippy --workspace --features full -- -D warningspasses (0 warnings)cargo nextest run --workspace --features full --lib --bins— all 5790 tests passprune_tool_outputs_preserves_overflow_reference,prune_stale_tool_outputs_preserves_overflow_reference_in_tool_output,prune_stale_tool_outputs_preserves_overflow_reference_in_tool_resultCloses #1818