Conversation
github-actions
bot
added
documentation
…ory, bfs_at_timestamp Add 14 unit tests covering boundary conditions and happy paths for three methods added in #1775: - edges_at_timestamp: valid_from==ts inclusive, valid_to==ts exclusive (with ts-1s boundary pair), multiple edges on same entity, no-edge entity - edge_history: basic ordering, limit truncation (with pre-condition proof), non-matching relation, empty entity, fact substring filtering (subset proof) - bfs_at_timestamp: zero hops, expired intermediate blocks traversal, disconnected entity, reverse direction, valid_to==ts exclusive boundary Closes #1776
bug-ops
force-pushed
the
test-memory-add-direct-unit-te
branch
from
2896234 to
209df73
Compare
github-actions
bot
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1776
Summary
GraphStoremethods added in feat(memory): temporal versioning on graph memory edges #1775Tests added
edges_at_timestamp (4 tests)
valid_from_inclusive: edge withvalid_from==tsis visible attsvalid_to_exclusive: edge withvalid_to==tsis NOT visible atts; also asserts visibility atts-1smultiple_edges_same_entity: returns all matching edges for an entityno_edges_returns_empty: returns empty for an entity with no edges at timestampedge_history (5 tests)
basic_history: returns all versions ordered by timestamp (strict>ordering on distinct timestamps)limit_parameter: pre-condition proves 5 rows exist; limit=2 returns exactly 2non_matching_relation_returns_empty: filter with no matches returns emptyempty_entity: entity with no edges returns empty historyedge_history_fact_substring_filters_subset: structural proof that filtered count < total countbfs_at_timestamp (5 tests)
zero_hops: depth=0 returns only the start entity (with real temporal data in range)expired_intermediate_blocks: expired A→B edge prevents reaching C even with active B→Cdisconnected_entity: entity with no edges returns only itselfreverse_direction: reverse traversal includes edge presence assertionvalid_to_boundary: edge withvalid_to==tsis not traversed atts; visible atts-1sTest plan
All 5591 workspace tests pass.