feat(memory): validate temporal_decay_rate on deserialization#1783
Merged
feat(memory): validate temporal_decay_rate on deserialization#1783
Conversation
github-actions
bot
added
enhancement
Reject NaN, Inf, negative values, and values outside [0.0, 10.0] with a descriptive error. Invalid configs now fail at startup instead of producing silent NaN scores during graph recall scoring. Closes #1777
bug-ops
force-pushed
the
feat-memory-validate-temporal-
branch
from
c8a20cc to
96ffad0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_temporal_decay_ratecustom serde deserializer inGraphConfig[0.0, 10.0]with a descriptive errorCloses #1777
Test plan
graph_config_temporal_decay_rate_negative_rejected—-0.1via TOML failsgraph_config_temporal_decay_rate_above_max_rejected—10.1via TOML failsgraph_config_temporal_decay_rate_inf_rejected—+Infvia JSON overflow failsgraph_config_temporal_decay_rate_neg_inf_rejected—-Infvia JSON overflow failsgraph_config_temporal_decay_rate_valid_zero—0.0passesgraph_config_temporal_decay_rate_valid_mid—5.0passesgraph_config_temporal_decay_rate_valid_max—10.0passesgraph_config_defaults— assertstemporal_decay_rate == 0.0graph_config_toml_round_trip— assertstemporal_decay_ratesurvives round-trip