feat(init): add hard_compaction_threshold prompt to --init wizard (#1719)#1763
Merged
feat(init): add hard_compaction_threshold prompt to --init wizard (#1719)#1763
Conversation
) Add hard_compaction_threshold prompt to step_memory() after the soft threshold prompt, with cross-field validation (hard > soft) and is_finite() guards. Store in WizardState (default 0.90) and write to config.memory.hard_compaction_threshold in build_config(). Also adds custom Default impl for WizardState with valid sentinels (0.70/0.90), explanatory comment on the hard threshold loop (dialoguer API constraint), and 4 unit tests covering default, custom, boundary, and inverted (dumb-mapper) scenarios.
github-actions
bot
added
enhancement
github-actions
bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hard_compaction_thresholdprompt tostep_memory()in the--initwizard, after the existing soft threshold promptWizardState(default 0.90) and writes it toconfig.memory.hard_compaction_thresholdinbuild_config()is_finite()guards on both promptsChanges
src/init.rs: addhard_compaction_thresholdfield toWizardStatewith customDefault(0.70/0.90 sentinels), add hard threshold prompt loop instep_memory(), write value inbuild_config()CHANGELOG.md: add entry to[Unreleased] ### AddedTest plan
cargo +nightly fmt --check— passcargo clippy --workspace --features full -- -D warnings— passcargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins— 5514 passedcargo run -- --initand verify wizard prompts for both soft and hard thresholds in sequencehard_compaction_thresholdvalueCloses #1719