refactor: split config/types.rs and semantic.rs into domain modules#1756
Merged
refactor: split config/types.rs and semantic.rs into domain modules#1756
Conversation
… semantic.rs Split crates/zeph-core/src/config/types.rs (3331 lines) into 11 domain modules under config/types/: agent, channels, defaults, experiment, features, learning, logging, memory, providers, security, ui. All types re-exported from config/mod.rs; no change to serialized TOML format. Split crates/zeph-memory/src/semantic.rs (3335 lines) into 7 sub-modules under semantic/: recall, algorithms, summarization, cross_session, corrections, graph, mod. Public API unchanged. Tests split into semantic/tests/ sub-modules. No file exceeds the 500-line (config) or 600-line (semantic) limits. Closes #1735, Closes #1736
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/zeph-core/src/config/types.rs(3331 lines) into 11 domain modules underconfig/types/: agent, channels, defaults, experiment, features, learning, logging, memory, providers, security, ui. All types re-exported fromconfig/mod.rs; no change to serialized TOML format.crates/zeph-memory/src/semantic.rs(3335 lines) into 7 sub-modules undersemantic/: recall, algorithms, summarization, cross_session, corrections, graph, mod. Public API unchanged. Tests split intosemantic/tests/sub-modules.Verification
cargo +nightly fmt --check: cleancargo clippy --workspace --features full -- -D warnings: cleancargo nextest run --config-file .github/nextest.toml --workspace --features full --lib --bins: 5427 passed, 0 failedCloses #1735, Closes #1736