refactor(memory): Arc-wrap EmbeddingStore and FuturesUnordered context preparation (#1223)#1244
Merged
refactor(memory): Arc-wrap EmbeddingStore and FuturesUnordered context preparation (#1223)#1244
Conversation
…t preparation (#1223) Prerequisite refactors for graph memory epic (#1222): - Wrap EmbeddingStore in Arc<EmbeddingStore> inside SemanticMemory for shared access from future background extraction tasks - Replace dual cfg-gated try_join! blocks in prepare_context with FuturesUnordered + ContextSlot enum for extensible concurrent context fetching without combinatorial cfg explosion - Preserve ContentSanitizer integration from #1199 across all context source paths
github-actions
bot
added
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmbeddingStoreinArc<EmbeddingStore>insideSemanticMemoryfor shared access from future background extraction taskstry_join!blocks inprepare_contextwithFuturesUnordered+ContextSlotenum for extensible concurrent context fetchingContentSanitizerintegration from [SEC-1.4] ContextBuilder sanitizer integration #1199 across all context source pathsPrerequisite refactors for graph memory epic (#1222). Resolves #1223.
Changes
crates/zeph-memory/src/semantic.rsqdrantfield:Option<EmbeddingStore>->Option<Arc<EmbeddingStore>>crates/zeph-memory/src/testing.rsmock_semantic_memory()wraps EmbeddingStore inArc::new()crates/zeph-core/src/agent/context.rsContextSlotenum +FuturesUnorderedpattern replacingtry_join!CHANGELOG.md[Unreleased]Test plan
cargo +nightly fmt --checkpassescargo clippy --workspace --features full -- -D warningspassescargo nextest run --workspace --features full --lib --bins: 3987 passed, 0 failed