-
Notifications
You must be signed in to change notification settings - Fork 3
feat(tools): migrate blocklist/confirm_patterns to permission rules #249
Copy link
Copy link
Closed
Labels
toolsTool execution and MCP integrationTool execution and MCP integration
Description
Problem
ShellExecutor still uses legacy blocked_commands and confirm_patterns fields. These should map to the new PermissionPolicy system.
Solution
- Convert
blocked_commandsentries to{ pattern, action: Deny }rules - Convert
confirm_patternsentries to{ pattern, action: Ask }rules - Keep old config fields as backward-compatible aliases (deserialized into PermissionPolicy)
- Replace
is_dangerous()+should_confirm()checks in ShellExecutor with singlePermissionPolicy::check(tool_id, input)call
Acceptance Criteria
- Old
blocked_commandsconfig auto-converted to deny rules - Old
confirm_patternsconfig auto-converted to ask rules - ShellExecutor uses PermissionPolicy for all permission checks
- Backward compatibility: existing configs work without changes
- Tests for migration logic
Part of #247 (M19 Phase C)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
toolsTool execution and MCP integrationTool execution and MCP integration