Skip to content

fix(tools): AuditLogger should log error on serialization failure instead of silently dropping #2438

@bug-ops

Description

@bug-ops

Context

In crates/zeph-tools/src/audit.rs, AuditLogger::log() silently drops audit entries when serde serialization fails (lines 89-91). No tracing::error! is emitted.

Impact

In production, a broken AuditEntry serialization would silently disappear from the JSONL audit log with no indication. This is a compliance gap — audit logs must be complete.

Fix

Replace the silent drop with a tracing::error!("audit entry serialization failed: {err}") so failures are observable in logs.

Related

Metadata

Metadata

Assignees

Labels

P3Research — medium-high complexity

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions