Skip to content

docs(classifiers): document FeedbackVerdict/JudgeVerdict coupling to prevent field divergence #2250

@bug-ops

Description

@bug-ops

Context

Identified during Phase 2 (#2200) impl-critique as M3 (non-blocking).

Problem

FeedbackVerdict in zeph-llm was created as a local copy of JudgeVerdict from zeph-core to avoid a circular dependency (zeph-llm cannot depend on zeph-core). The two structs have identical fields today but there is no compile-time mechanism to keep them in sync. Future changes to JudgeVerdict (adding a field, renaming kind variants) will silently diverge from FeedbackVerdict.

Expected

Document the coupling in both struct definitions with a // NOTE: comment explaining the relationship and which fields must stay in sync. Consider extracting shared verdict types to a zeph-types crate (no deps) to provide compile-time coupling without circular dependency.

Metadata

Metadata

Assignees

Labels

P3Research — medium-high complexityenhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions