-
Notifications
You must be signed in to change notification settings - Fork 2
Remove redundant schema feature gate from zeph-llm #2100
Copy link
Copy link
Closed
Labels
choreMaintenance tasksMaintenance tasksllmzeph-llm crate (Ollama, Claude)zeph-llm crate (Ollama, Claude)size/MMedium PR (51-200 lines)Medium PR (51-200 lines)
Description
Summary
zeph-llm declares a schema feature gating schemars as an optional dependency with default = ["schema"]. However, schemars is a non-optional dependency in 7 other workspace crates (zeph-core, zeph-tools, zeph-skills, zeph-mcp, zeph-acp, zeph-orchestration, zeph-memory). Since all these crates are compiled in every build, schemars is always present in the dependency graph — making the 37 #[cfg(feature = "schema")] annotations in zeph-llm redundant.
Changes
- Make
schemarsa non-optional dependency incrates/zeph-llm/Cargo.toml - Remove
schemafeature declaration anddefault = ["schema"] - Remove 37
#[cfg(feature = "schema")]annotations from zeph-llm source files - Remove
"zeph-llm/schema"from rootCargo.tomlfeature propagation (if any)
Impact
- Eliminates 37 cfg annotations — cleaner code, less cognitive overhead
- No behavioral change: schemars was always compiled via other crates
- No binary size change
Risk
LOW. The feature was always effectively enabled.
Analysis
Full details: .local/reports/feature-stabilization-analysis.md, Section 5.3
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
choreMaintenance tasksMaintenance tasksllmzeph-llm crate (Ollama, Claude)zeph-llm crate (Ollama, Claude)size/MMedium PR (51-200 lines)Medium PR (51-200 lines)