-
Notifications
You must be signed in to change notification settings - Fork 2
perf(memory): double guidelines load in multi-chunk summarization path #1805
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or requestmemoryzeph-memory crate (SQLite)zeph-memory crate (SQLite)performancePerformance improvementsPerformance improvements
Description
Summary
In crates/zeph-core/src/agent/context/summarization.rs, summarize_messages_with_budget loads compression guidelines at line 1303, and then summarize_messages internally loads them again at ~line 367 when called via the multi-chunk fallback at line 1355. This results in two SQLite queries for the same data.
Fix
Load guidelines once in summarize_messages_with_budget and pass them as a parameter to summarize_messages, or cache them at the call site.
Not a correctness issue; acceptable for now.
Identified by code reviewer (REVIEW-10) during ACON compression guidelines PR (#1647) review.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestmemoryzeph-memory crate (SQLite)zeph-memory crate (SQLite)performancePerformance improvementsPerformance improvements