-
Notifications
You must be signed in to change notification settings - Fork 2
Split semantic.rs into recall, summarization, and cross-session sub-modules #1736
Copy link
Copy link
Closed
Closed
Copy link
Labels
refactorCode refactoring without functional changesCode refactoring without functional changes
Description
Problem
crates/zeph-memory/src/semantic.rs is 3335 lines. It handles recall, summarization, MMR re-ranking, temporal decay, cross-session search, graph extraction, corrections, and session summaries — all in a single file.
Proposed Changes
Extract concern-specific modules under semantic/:
semantic/recall.rs—recall(),apply_mmr(),apply_temporal_decay(),RecalledMessagesemantic/summarization.rs—summarize_conversation(), structured summary generation,Summarysemantic/cross_session.rs— cross-session search,SessionSummaryResult, session summary retrievalsemantic/corrections.rs— correction storage, embedding, and retrievalsemantic/graph.rs—extract_and_store(),ExtractionStats,GraphExtractionConfigsemantic/mod.rs—SemanticMemorystruct definition and delegation methods
Acceptance Criteria
- No file in
semantic/exceeds 600 lines - Public API unchanged (same re-exports from
crates/zeph-memory/src/lib.rs) - All tests pass
Files
crates/zeph-memory/src/semantic.rs(3335 lines)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
refactorCode refactoring without functional changesCode refactoring without functional changes