-
Notifications
You must be signed in to change notification settings - Fork 2
Reduce clippy::too_many_lines suppressions in agent module #1734
Copy link
Copy link
Closed
Labels
refactorCode refactoring without functional changesCode refactoring without functional changes
Description
Problem
55 #[allow(clippy::too_many_lines)] suppressions exist across the workspace, with 9 concentrated in crates/zeph-core/src/agent/mod.rs. These indicate functions that exceed the configured line limit and should be decomposed.
Key offenders in agent/mod.rs:
new()andnew_with_registry_arc()(constructor logic)run()main agent loop- Context assembly methods
- Plan execution methods
Proposed Changes
- Extract channel message dispatch logic into dedicated handler functions
- Move plan execution flow into the
orchestrationmodule - Decompose context assembly into
context_managermethods - Split MCP/skill reload handling into their respective modules
- Target: reduce total suppressions to <= 10 workspace-wide
Files
crates/zeph-core/src/agent/mod.rs(primary, 9 suppressions)- Various other files (46 suppressions across workspace)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
refactorCode refactoring without functional changesCode refactoring without functional changes