Skip to content

Reduce clippy::too_many_lines suppressions in agent module #1734

@bug-ops

Description

@bug-ops

Problem

55 #[allow(clippy::too_many_lines)] suppressions exist across the workspace, with 9 concentrated in crates/zeph-core/src/agent/mod.rs. These indicate functions that exceed the configured line limit and should be decomposed.

Key offenders in agent/mod.rs:

  • new() and new_with_registry_arc() (constructor logic)
  • run() main agent loop
  • Context assembly methods
  • Plan execution methods

Proposed Changes

  1. Extract channel message dispatch logic into dedicated handler functions
  2. Move plan execution flow into the orchestration module
  3. Decompose context assembly into context_manager methods
  4. Split MCP/skill reload handling into their respective modules
  5. Target: reduce total suppressions to <= 10 workspace-wide

Files

  • crates/zeph-core/src/agent/mod.rs (primary, 9 suppressions)
  • Various other files (46 suppressions across workspace)

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorCode refactoring without functional changes

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions