Upgrade build dependencies #629
Conversation
elliotmjackson
force-pushed
the
main
branch
2 times, most recently
from
960dedd to
b1e2c31
Compare
Signed-off-by: Elliot Jackson <[email protected]>
Signed-off-by: Elliot Jackson <[email protected]>
Signed-off-by: Elliot Jackson <[email protected]>
Signed-off-by: Elliot Jackson <[email protected]>
Signed-off-by: Elliot Jackson <[email protected]>
akshayjshah
left a comment
akshayjshah
left a comment
There was a problem hiding this comment.
I'm confused by the :validate_go change. Can you explain what's happening to me?
|
|
||
| alias( | ||
| name = "go_default_library", | ||
| actual = ":validate_go", |
There was a problem hiding this comment.
I don't understand. If we've removed this, why are we changing to //validate:validate_go elsewhere in this diff?
There was a problem hiding this comment.
adding offline comments here....
The only thing i did is get the dockerfile to run on arm machines and update the go version, consequently the go mod and bazel/repositories.bzl with later versions…once i did this, i synced up the bazel repos from the go mod with
bazel run //:gazelle -- update-repos -from_file=go.mod -prune -to_macro=dependencies.bzl%go_third_partythats when it went as made the huge diff 😛 I dont have a bazel-vocab so please excuse me. You can see everything bazel/gazelle did in commit ea5d03e… Updating bazel rules in bazel/repositories.bzl was all me - needed to happen to enable an arm build. Trying to simulate amd was impossible, my machine quickly ran out of memory.
Signed-off-by: Elliot Jackson <[email protected]>
elliotmjackson
force-pushed
the
main
branch
from
4a955bb to
dd47611
Compare
Signed-off-by: Elliot Jackson <[email protected]>
Signed-off-by: Elliot Jackson <[email protected]>
akshayjshah
left a comment
akshayjshah
left a comment
There was a problem hiding this comment.
Looks good! After landing this, can you upgrade envoyproxy/envoy and make sure everything works?
2 participants
Uh oh!
There was an error while loading. Please reload this page.