Repository navigation
Keep a leading U+FEFF when decoding binary strings - #1572
Merged
Merged
Conversation
getTextEncoding() built its UTF-8 decoders without ignoreBOM. The WHATWG decoder strips a leading U+FEFF, so fromBinary dropped that code point from string fields. Both decoders now set ignoreBOM, and the strict decoder still uses fatal. Adds a decodeUtf8 case and a StringValue round trip.
|
|
timostamm
approved these changes
Nov 2, 2026
timostamm
left a comment
timostamm
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I've pushed up corresponding docs changes and additional tests, and updated the PR description to call out the behavioral change. LGTM!
This comment was marked as low quality.
This comment was marked as low quality.
Merged
markharding
pushed a commit
to futo-org/Harbor
that referenced
this pull request
Nov 10, 2026
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@bufbuild/protobuf](https://protobufes.com/) ([source](https://github.com/bufbuild/protobuf-es/tree/HEAD/packages/protobuf)) | [`2.16.0` → `2.17.0`](https://renovatebot.com/diffs/npm/@bufbuild%2fprotobuf/2.16.0/2.17.0) |  |  | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/2097) for more information. --- ### Release Notes <details> <summary>bufbuild/protobuf-es (@​bufbuild/protobuf)</summary> ### [`v2.17.0`](https://github.com/bufbuild/protobuf-es/releases/tag/v2.17.0) [Compare Source](bufbuild/protobuf-es@v2.16.0...v2.17.0) <!-- Release notes generated using configuration in .github/release.yaml at main --> #### What's Changed This release fixes several bugs, and some of the fixes change behavior in edge cases. - Unknown fields in map entries should be skipped by [@​ajeetdsouza](https://github.com/ajeetdsouza) in [#​1544](bufbuild/protobuf-es#1544) - Document plugin options for each bundler and runtime by [@​timostamm](https://github.com/timostamm) in [#​1555](bufbuild/protobuf-es#1555) - Read ASCII strings without creating a subarray in BinaryReader by [@​intech](https://github.com/intech) in [#​1566](bufbuild/protobuf-es#1566) - Add docs page on using Protobuf-ES with grpc-node by [@​sudorandom](https://github.com/sudorandom) in [#​1571](bufbuild/protobuf-es#1571) - Fix nanos upper bound in timestampToJson error message by [@​ajeetdsouza](https://github.com/ajeetdsouza) in [#​1575](bufbuild/protobuf-es#1575) - Emit the first name for aliased enum values in JSON by [@​vera-rubin](https://github.com/vera-rubin) in [#​1570](bufbuild/protobuf-es#1570) - Keep a leading U+FEFF when decoding binary strings by [@​devtechedge](https://github.com/devtechedge) in [#​1572](bufbuild/protobuf-es#1572) #### New Contributors - [@​intech](https://github.com/intech) made their first contribution in [#​1566](bufbuild/protobuf-es#1566) - [@​vera-rubin](https://github.com/vera-rubin) made their first contribution in [#​1570](bufbuild/protobuf-es#1570) - [@​devtechedge](https://github.com/devtechedge) made their first contribution in [#​1572](bufbuild/protobuf-es#1572) **Full Changelog**: <bufbuild/protobuf-es@v2.16.0...v2.17.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - "before 9am on tuesday" - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4yMDYuMiIsInVwZGF0ZWRJblZlciI6IjQ0LjIwNi4yIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZSJdfQ==--> Reviewed-on: https://code.futo.org/harbor/harbor/pulls/2258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1567: A leading U+FEFF in a protobuf string is part of the value, not a byte-order mark. protobuf-es created its
TextDecoderwithoutignoreBOM, sofromBinarysilently removed one leading U+FEFF from every string it reads.This PR passes
ignoreBOM: trueto both the lenient and the strict decoder ingetTextEncoding(). As a result, strings decoded by protobuf-es now keep a leading U+FEFF.If you depended on the old behavior, strip the character yourself after decoding, for example
value.replace(/^\uFEFF/, "").