Skip to content
This repository was archived by the owner on Sep 1, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bufbuild/connect-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.0
Choose a base ref
...
head repository: bufbuild/connect-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.1
Choose a head ref
  • 3 commits
  • 8 files changed
  • 2 contributors

Commits on Dec 9, 2022

  1. Import base go file even if there are no base types required (connect…

    …rpc#418)
    
    If a service solely requires types from other packages the result is
    that the connect services don't have access to the filedescriptorsets.
    This causes a lot of issues such as server reflection failing.
    
    This PR blank imports the base go file that should always exist
    
    For the proto file:
    
    ```proto
    // service/eliza.proto
    syntax = "proto3";
    package service;
    import "models/eliza.proto";
    
    service ElizaService {
    }
    
    // models/eliza.proto
    syntax = "proto3";
    package ext;
    
    message SayRequest {
      string sentence = 1;
    }
    message SayResponse {
      string sentence = 1;
    }
    ```
    
    The following diff occurs in the generated `eliza.connect.go` code
    ```diff
    package serviceconnect
    
    import (
    	context "context"
    	errors "errors"
    	models "github.com/bufbuild/connect-demo/internal/gen/buf/connect/demo/eliza/v1/models"
    +	_ "github.com/bufbuild/connect-demo/internal/gen/buf/connect/demo/eliza/v1/service"
    	connect_go "github.com/bufbuild/connect-go"
    	http "net/http"
    	strings "strings"
    )
    
    ```
    
    There is no change if the base types are already in the
    `service/eliza.proto` (the way we recommend using proto files)
    
    Closes TCN-786
    joshcarp authored Dec 9, 2022
    Configuration menu
    Copy the full SHA
    528158c View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Configuration menu
    Copy the full SHA
    4c75d85 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Prepare for v1.4.1 (connectrpc#425)

    Prepare for the next release, and fix connectrpc#424.
    akshayjshah authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    eab7f2a View commit details
    Browse the repository at this point in the history
Loading