Some modifications to plugin and theme admin columns#16
Merged
bueltge merged 1 commit intobueltge:masterfrom Feb 25, 2015
peteredwards:master
Merged
Some modifications to plugin and theme admin columns#16bueltge merged 1 commit intobueltge:masterfrom peteredwards:master
bueltge merged 1 commit intobueltge:masterfrom
peteredwards:master
Conversation
pull request from changes made at home over last week
Owner
|
Thanks a lot for this very helpful improvement, was on my todo list. |
Owner
|
Manual merged. Again many thanks for the pull request! |
Contributor
Author
|
My pleasure - thanks for all the work you have done on this plugin so far. |
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code to get information about active plugins and themes on different blogs was a bit inefficient, so I've modified it to use a site transient. I also noticed that the active plugins and themes were not displaying some sites which I know were using the themes/plugins. The bug here was in the use of the wp_get_sites function to retrieve site information from wordpress. The default limit for the number of sites retrieved using this function is 100, whereas I have 131 sites on my network, so 31 of the sites were not being retrieved.