Update BP_Core_Nav so that it uses BP Rewrites
#77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `BP_Core::parse_query()` method and differ the `bp_core_action_search_site` action to the `bp_parse_query` hook.
9 PHPUnit tests still need to be adjusted
thebrandonallen
pushed a commit
to thebrandonallen/buddypress
that referenced
this pull request
Mar 23, 2023
- Remove all components `$parent_url` attributes when setting sub nav items. - Only use the `bp_core_create_nav_link()` `$link` attribute argument & the `bp_core_create_subnav_link()` `$parent_url` attribute argument if specified to preserve backward compatibility. - Migrates the Community search feature so that it uses BP Rewrites. - Perform some `bp_loggedin_user_domain()` in favor of `bp_loggedin_user_url()`. - Update some PHPUnit tests. Props r-a-y, johnjamesjacoby, boonebgorges Closes buddypress/buddypress#77 See #4954 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13441 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jul 28, 2023
- Remove all components `$parent_url` attributes when setting sub nav items. - Only use the `bp_core_create_nav_link()` `$link` attribute argument & the `bp_core_create_subnav_link()` `$parent_url` attribute argument if specified to preserve backward compatibility. - Migrates the Community search feature so that it uses BP Rewrites. - Perform some `bp_loggedin_user_domain()` in favor of `bp_loggedin_user_url()`. - Update some PHPUnit tests. Props r-a-y, johnjamesjacoby, boonebgorges Closes buddypress/buddypress#77 See #4954 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13441 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/omt-buddypress-sync
that referenced
this pull request
Nov 2, 2025
- Remove all components `$parent_url` attributes when setting sub nav items. - Only use the `bp_core_create_nav_link()` `$link` attribute argument & the `bp_core_create_subnav_link()` `$parent_url` attribute argument if specified to preserve backward compatibility. - Migrates the Community search feature so that it uses BP Rewrites. - Perform some `bp_loggedin_user_domain()` in favor of `bp_loggedin_user_url()`. - Update some PHPUnit tests. Props r-a-y, johnjamesjacoby, boonebgorges Closes buddypress/buddypress#77 See #4954 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13441 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/buddypress-sync
that referenced
this pull request
Nov 3, 2025
- Remove all components `$parent_url` attributes when setting sub nav items. - Only use the `bp_core_create_nav_link()` `$link` attribute argument & the `bp_core_create_subnav_link()` `$parent_url` attribute argument if specified to preserve backward compatibility. - Migrates the Community search feature so that it uses BP Rewrites. - Perform some `bp_loggedin_user_domain()` in favor of `bp_loggedin_user_url()`. - Update some PHPUnit tests. Props r-a-y, johnjamesjacoby, boonebgorges Closes buddypress/buddypress#77 See #4954 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13441 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP_Core_Navis the class we use to set up BuddyPress single item navigations. It now only needs slugs to build URLs.parent_urlattributes when setting sub nav items.linkfor the main nav item or aparent_urlfor the sub nav item, it will use this link to preserve backward compatibility.Trac ticket: https://buddypress.trac.wordpress.org/ticket/4954
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.