Update a test about bp_attachments_get_allowed_types()
#401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test `document` types instead of `image` ones as BP image supported types are not the same than WordPress.
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Nov 3, 2024
Use a more meaningful test checking for `document` file types. Fixes #9251 Closes buddypress/buddypress#401 git-svn-id: http://buddypress.svn.wordpress.org/trunk@14067 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/omt-buddypress-sync
that referenced
this pull request
Nov 2, 2025
Use a more meaningful test checking for `document` file types. Fixes #9251 Closes buddypress/buddypress#401 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14067 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
emaralive
pushed a commit
to emaralive/buddypress-sync
that referenced
this pull request
Nov 3, 2025
Use a more meaningful test checking for `document` file types. Fixes #9251 Closes buddypress/buddypress#401 git-svn-id: https://buddypress.svn.wordpress.org/trunk@14067 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
documenttypes instead ofimageones as BP image supported types are not the same than WordPress.Trac ticket: https://buddypress.trac.wordpress.org/ticket/9251
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.